Submitting Documentation
See Contributing to Projects for general instructions on contributing to Vaadin. You should separate enhancements, fixes, and new features into different pull requests. Check your changes for basic style violations.
To submit a contribution, you need to create a feature branch and push that for review.
As a contributor, you need to:
Fork the repository in GitHub.
Clone it locally to edit it.
Show code
bash
Expand code
Make a new branch for the improvements.
Show code
bash
Expand code
Make the changes.
Show code
bash
Expand code
Push the changes to the branch in your forked repository.
bash
Expand code
Create a pull request in the Docs repository.
Your change should show there.
Click Compare & pull request.
In the Open a pull request form, enter a title for the PR, an optional comment, and click Create pull request.
Make and push fixes requested in the review.
Note that you do not need to set the upstream again, but can just
git push
the changes.Show code
bash
Expand code
Vaadin Developers
Vaadin developers with write access to the Docs repository should (like above):
Clone the repository to edit it.
Make a new branch for the improvements.
Make the changes.
- Preview locally while writing.
Push the changes to the new branch in the Docs repository.
-
Open the Docs repository page in browser.
Your change should show there.
Click Compare & pull request.
Add reviewers
Review in the development team.
Component code examples (TypeScript and Java) need to be approved by
tomivirkki
, , oryuriy-fix
.Can add for documentation style review, or ask to do separately outside the development time box.
No dedicated proofreader is currently available, but
magi42
can be asked for review.
Make fixes requested in the review.
Merge the PR by yourself or have the team lead or main author do it.
Merging a pull request has the following requirements:
The PR must have been accepted in review
Deployment preview build must finish successfully
You must have signed the Contributor License Agreement
The following requirements are optional and not enforced:
- Vale checks are successful
For contributions, the reviewer merges the pull request once it has been approved.